Fixes #1588: <C-a> does wrong things if cursor is to the right of a number (and there's a number on the next line) #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfn
reviewed
May 1, 2017
| return; | ||
| } | ||
| start = start.getWordRight(); | ||
| wordEnd = start.getCurrentWordEnd(); | ||
| wordEnd = start.getCurrentWordEnd(true); |
There was a problem hiding this comment.
Gah - we need to use more keyword arguments. e.g. i have no idea what this true means, but if it was start.getCurrentWordEnd({ exclusive: true }), that would be much better.
Not pertinent to this PR, but it's been on my mind.
|
LGTM. Thanks for the PR! :) |
|
I think we also just need to comment and explain all of our functions haha. |
|
That would help too. :) I like object arguments because they are like enforced comments. |
Chillee
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from a bug in the IterateWords helper function used. The function should stop at the end of the line, but since wordEnd() isn't at lineEnd(), it continues onto the next line and takes characters from there.
Fixes another small bug as well. Namely,
does not do right things.