Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade typescript 2.2.1->2.3.2. tslint 3.10.2->2.3.2. Fix errors #1614

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Upgrade typescript 2.2.1->2.3.2. tslint 3.10.2->2.3.2. Fix errors #1614

merged 1 commit into from
Apr 30, 2017

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Apr 30, 2017

Upgrade tslint

@jpoon jpoon merged commit 675bc23 into master Apr 30, 2017
@jpoon jpoon deleted the upgrade_tslint branch April 30, 2017 06:25
@johnfn
Copy link
Member

johnfn commented Apr 30, 2017

At some point we should do strict: true in our tsconfig.json rather than our hastily assembled set of strict properties.

Also I want to merge this but it's kind of hard with all the other PRs that don't have this merged in currently... hm

@jpoon
Copy link
Member Author

jpoon commented Apr 30, 2017

Oh, did you want me to back it out then? :)

@johnfn
Copy link
Member

johnfn commented Apr 30, 2017

Ehh, nah. I'm a fan of YDD (yolo-driven development). If anything bad happens we can just let people know, and this is a definite improvement.

@jpoon
Copy link
Member Author

jpoon commented Apr 30, 2017

Also messed up on the commit message:
tslint: 3.10.2 -> 5.1.0

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpoon @johnfn