Select in Visual mode when scrolling #1591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't merge this before Code ships. |
|
Ah, awesome! Thanks for the vscode-side work, @rebornix! |
|
Does this mean using the scrollwheel will expand / contract the selection? |
|
Can you bring this one up to date so that it is ready to be merged as well |
|
I think this also fixes #885 |
|
@rebornix can you rebase/update this one? |
|
@rebornix You want me to finish this one? |
|
I'll do this, sorry for being late
…On Tue, May 23, 2017 at 23:49 Horace He ***@***.***> wrote:
@rebornix <https://github.com/rebornix> You want me to finish this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1591 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA1heHIO7Pbl34lvHgZdHA7avRCapCtcks5r87a0gaJpZM4NKtgJ>
.
|
|
This doesn't work once you have made it to the start or end of the pane, try to do it a few times and you will see it gets stuck |
|
@xconverge This is due to something on our end. I'm guessing that we're not updating cursor position properly. |
|
Closed in favor of this PR: #1859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref microsoft/vscode#22147 (comment) and fixes #907
With next version of Code, we can expand selection while scrolling.