Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1533: <Copy> not activating when <C-c> is pressed #1542

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Fixes #1533: <Copy> not activating when <C-c> is pressed #1542

merged 3 commits into from
Apr 21, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented Apr 20, 2017

We need to handle ctrl+c separately, as vim.overrideCopy should override vim.useCtrlKeys.

I plan on adding tests later today.

xconverge
xconverge reviewed Apr 20, 2017
View reviewed changes
Copy link
Member

@xconverge xconverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the comment slightly

@xconverge
Copy link
Member

thanks!

@xconverge xconverge merged commit c035b81 into VSCodeVim:master Apr 21, 2017
@Chillee Chillee mentioned this pull request Apr 27, 2017
Closed
@Chillee Chillee changed the title Fixed issue #1533 Fixes #1533: <Copy> not activating when <C-c> is pressed May 2, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xconverge xconverge xconverge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chillee @xconverge