Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cmd_line commands to remapper #1516

Merged
merged 5 commits into from
Apr 16, 2017
Merged

added cmd_line commands to remapper #1516

merged 5 commits into from
Apr 16, 2017

Conversation

xconverge
Copy link
Member

This fixes #1166

example usage:

       {
           "before":["<C-n>"],
           "after":[],
            "commands": [
                {
                    "command": ":nohl",
                    "args": []
                }
            ]
       },
       {
           "before":["<C-r>"],
           "after":[],
            "commands": [
                {
                    "command": ":%s/test/123/g",
                    "args": []
                }
            ]
       }

@@ -56,6 +56,11 @@ class ConfigurationClass {
/* tslint:disable:forin */
// Disable forin rule here as we make accessors enumerable.`
for (const option in this) {
// Some options are internal states and should not be reinitialized
if (option === "hl") {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move this flag to vimState.globalState instead of Configuration so that this can be removed

@johnfn
Copy link
Member

johnfn commented Apr 16, 2017

Awesome. LGTM

@xconverge xconverge merged commit b8fd6a1 into VSCodeVim:master Apr 16, 2017
@xconverge xconverge deleted the add-vim-cmdline-to-remapper branch April 16, 2017 16:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remap : commands
2 participants