make surround repeatable with dot #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there should be a better way. Just hold on to this guy: https://github.com/VSCodeVim/Vim/blob/master/src/mode/modeHandler.ts#L105 and then re-execute with him when the user presses |
|
No the problem is getting the operators and movement for the range. It needs to be recalculated based on new position |
|
Example: ysaw" we need to redo aw |
|
Ah I see. So you'd have to refactor him to change the Range into a Motion or something. Meh, this is fine if you don't want to do that. |
|
it is SUPER handy to have, that's for sure... I am not sure I know how to do the motion and either way there is some sense of replaying it back, but then atleast the surround object is fully contained |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little funky but I don't think its too bad :)
This is to fix #1244
Any suggestions on a better way would be great... @johnfn