Navigate between view #1504
Merged
Navigate between view #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
reviewed
Apr 13, 2017
package.json
Outdated
| @@ -187,6 +187,31 @@ | |||
| "when": "editorTextFocus && vim.use<C-[> && !inDebugRepl" | |||
| }, | |||
| { | |||
| "key": "ctrl+w h", | |||
| "command": "extension.vim_navigateLeft", | |||
| "when": "vim.use<C-w>" | |||
There was a problem hiding this comment.
these are all for when !editorTextFocus right? we should add !editorTextFocus
Because then the actions.ts ones cover when we are focused?
|
This is awesome. Would love to see it land. |
|
I didn't even read/see who you were :) |
|
This will save my life. |
|
I am not a huge fan of defining keybindings purely in package.json because then we can't remap them. :/ |
|
@johnfn I see your points. Let's see if |
|
I don't think this handles ctrl+w j and ctrl+w k right? |
|
@rebornix Any reason why only ctrl+w h/l is supported? |
|
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1375. Leverage new Code api to navigate between viewlets, panels, editors by -.
This is contributed by rebornix/Peng's personal account on his personal machine in personal time.