[WIP] change system clipboard library to a newer more maintained library #1487
Conversation
… try and resolve UTF-8 and chinese character issues
|
Tested both this and current master (node-copy-paste) library on Ubuntu and all Chinese characters seem to work great. This new library is also cool because it worked out of the box, no need to install xclip. Back to macOS to continue to try and figure this out... |
|
@rebornix this is starting to look great, but I wonder what should be fixed in the scope of this plugin, the copy paste plugin, or vscode Since you are the copy paste formatting expert for vscode perhaps you can help me out here Can you test this a bit? The key is mostly setting the LANG env variable for vscode to a UTF-8 compatible locale... |
|
@xconverge sure, I'm a Chinese expert and I'll give it a try. |
|
arg I can't get it to work for windows 10 :( , this test I just added fails on windows |
|
@xconverge copying Chinese characters works good. |
|
Too bad it doesn't work on windows yet :/ will see what I can do |
|
I opened sindresorhus/clipboardy#11 we will see if it gets any traction |
|
I am going to merge this for now actually since it FIXES the problem on osx and linux, uses a better supported library, and does not make windows worse (doesn't work correctly on master with old library either) |
|
@xconverge Hey wondering if Windows clipboard is still a standing issue? I want to push for microsoft/vscode#217. |
This library is being worked on consistently and is not stale with potential issues
Still having issues with the character • which I use for testing. Once it works perfectly with this I will also test chinese characters