fix multi line in 'at' and 'it' commands

[judocode]

Fixes #971, #1108, #1232, and #1300.

Remaining existing issues: cit does not enter insert mode when tag is empty, and it also doesn't return to the correct position when you run cit in the closing tag.

[johnfn]

Can you just use a simple for of loop here?

[johnfn]

Can you give the proper typings here, rather than using any? I think it's { name: string, type: "close" | "open", startPos: number, endPos: number }[]

[johnfn]

(And our code formatting conventions are const stack: type)

[johnfn]

Overall looks good to me. My biggest concern is that we have to parse the entire document every time we do a cit. How is the perf of that in a file such as actions.ts? (And you thought that file was huge for no reason. Of course not, it's to test perf concerns! 😉 )

[judocode]

@johnfn Hah... The performance was a concern of mine too, but I did some tests in very large html files (170,000+ characters) and saw no noticeable delay.

[xconverge]

@jrenton I think there was one other comment about using a for of loop, it is in our coding style guide

This is so close that I would like to see it in the next release!

[theamazingfedex]

Is there anything that I could do to help expedite this fix getting merged?

[judocode]

@theamazingfedex There are some underlying bugs within VSCodeVim itself outside of this issue relating to assumptions made in regards to changing/deleting text (at least the last I checked). They show themselves through various bugs that still exist with this, including:

• cit does not enter insert mode when tag is empty
• When you run cit in the closing tag, it doesn't return to the correct position.
• If a closing tag is the first character on a newline, it cannot properly close the tag.

Technically this should be able to be merged, but I kind of gave up when I kept running into bugs that were related to underlying issues with the plugin itself.

[Chillee]

So just to be clear, the underlying algorithm for finding the corresponding tags works fine, the issues are mainly related to where the cursor ends up after?

[judocode]

@Chillee Yes, mostly 😄

[Chillee]

Do you think they're fixable (just a massive pain), or is there some fundamental limitation with our current code structure?

Looking over your code for a bit, I think I know how to fix all 3 of the bugs you named, at least. They're kind of pain, but I think it's possible.

[johnfn]

There aren't any fundamental limitations to getting tag text objects to work. It's just more work. :)