Change easymotion decoration colors to use searchHighlight colors #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #1245 |
…sible to trigger though
xconverge
commented
Mar 26, 2017
| @@ -294,8 +324,6 @@ export class EasyMotion { | |||
| // Get keys after the depth we're at | |||
| var keystroke = marker.name.substr(this.accumulation.length); | |||
|
|
|||
| let fontColor = keystroke.length > 1 ? "orange" : "red"; | |||
There was a problem hiding this comment.
I am disappointed to take this out but am not sure how else I could accomplish it and still have it be readable
There was a problem hiding this comment.
decided to leave it in, and make fontcolor and background color change with a configuration flag instead
…ion option so that default behavior remains the same
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can get the same result without the library if we want, but it definitely cleans up the code
Also, I spent a while using different functions of it to manipulate the color wheel to try out different things for readability. Complementary font color, etc don't look good.
Black and white and using the light()/dark() luminosity formula seemed to give the best results.