Remapper cleanup key history #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xconverge
commented
Mar 21, 2017
•
xconverge
commented
- fixes using o then jj remapped to not deleting whitespace due to o checking for previous keys
… or O command. If jj was remapped to <esc> it would not properly remove whitespace after o due to leftover j in keyHistory.
jpoon
reviewed
Mar 22, 2017
src/actions/actions.ts
Outdated
| @@ -3615,7 +3615,7 @@ abstract class MoveByScreenLine extends BaseMovement { | |||
| let stop = Position.FromVSCodePosition(vscode.window.activeTextEditor.selection.end); | |||
|
|
|||
| // We want to swap the cursor start stop positions based on which direction we are moving, up or down | |||
| if (start.line < position.line) { | |||
| if (start.line < position.line && this.movementType === "up") { | |||
There was a problem hiding this comment.
Why do we need to check movementType == "up"?
There was a problem hiding this comment.
I will take a peek to have a better answer for you, I was just playing wack a mole.
There was a problem hiding this comment.
This will be a separate issue, it is too broken to fix with this, V H, V L, Vgjgjgj, and Vgkgkgk all need to work without breaking other screen line stuff
|
@xconverge noice. using your commit rights 👍 |
|
responsibly 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.