Update config options without restarting #1361
Conversation
| @@ -149,28 +153,28 @@ class ConfigurationClass { | |||
| /** | |||
| * Size of a tab character. | |||
| */ | |||
| @overlapSetting({ codeName: "tabSize", default: 8}) | |||
| @overlapSetting({ codeName: "tabSize", default: 8 }) | |||
There was a problem hiding this comment.
Haha I see my weird spacing habits are starting to rub off on you.
There was a problem hiding this comment.
Whoa, I didn't know that it was the standard style... I thought I was doing something weird.
|
Overall feedback: Instead of updating the remappers, could you just recreate them entirely - construct new ones? Ideally we only have one code path: addNewRemappers(), which gets called immediately and whenever a config update happens, rather than the 2 code paths we have right now. |
|
yep, makes sense |
|
LGTM, the only thing that I think we can change is guarding Vim from flooded configuration changes. |
|
Yeah this is awesome. It's super simple and an incredibly useful change. Imagine how many fewer questions we'll have to answer on Slack now 😉 |
This is really nice and was easy!
It exposes some weirdness with how we do remapping but o well.. let me know what you think