Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement % to jump to matching brace #134

Merged
merged 0 commits into from
Feb 10, 2016
Merged

Conversation

tma-isbx
Copy link

@tma-isbx tma-isbx commented Feb 3, 2016

Implement % in normal mode to jump to matching brace.

Basically, binds % to "editor.action.jumpToBracket".

@jpoon
Copy link
Member

jpoon commented Feb 3, 2016

Thanks for the PR!

From my testing, it seems like a partial implementation when relying on jumpToBracket as it only seems to jump to the matching brace when the brace is selected.

  • With VIM, %, it should jump to the next item in the line with a match.
  • and as we're relying on jumpToBracket no support C-style comments, C preprocessor matching

Judging from the caveats of this implementation, I'm OK with merging this PR unless any other contributors had objections?

@tma-isbx
Copy link
Author

tma-isbx commented Feb 3, 2016

Ah, yes. Sorry, I forgot to list the caveats.

Like all vim users using different subsets of functionality, this implementation met the subset that I used for %.

I was hoping this would be a good starter PR to get familiar with Extensions in general, and this extension in particular.

@tma-isbx
Copy link
Author

Oops. I was moving my master to track your master not realizing that would affect the pull request, and I guess 0 commits go merged into your master.

I can make a new pull request with the feature branch I had moved the commit to.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants