Support exact and inexact current word search

[rhys-vdw]

Rename CommandStar and CommandHash to CommandSearchCurrentWordExactForward and CommandSearchCurrentWorldExactBackward, which describe their effect. Also include regex word bounds in the search so that they act the same as in Vim.

Add CommandSearchCurrentWordForward and …Backward (commands g* and g# respectively), that match without word bounds.

Closes #1266

---

So this is mainly a copy+paste, I wasn't sure if there was an idiomatic approach to sharing behaviour between these two commands. Also I renamed the classes because it felt more sensible to name them after their effect than their keybindings (also it seemed strange to call the new one something like CommandGStar.

Let me know if there's anything stylistically or functionally wrong here, I'm happy to iterate on it.

[johnfn]

Other than the bit of duplication, this looks good to me. Thanks so much for the PR! :)

[johnfn]

Normally we share methods with static methods on one of the relevant classes.

[rhys-vdw]

Seems I need to update some tests... I started looking into this and found this test:

  newTest({
    title: "Can handle tricky *",
    start: ['|blah blahblah duh blah'],
    keysPressed: '*',
    end: ['blah blahblah duh |blah']
  });

Which superficially implies that the change I've made was already implemented? However, on further investigation this is actually behaving incorrectly. Either * or # will immediately jump to the final blah, but then pressing n will cycle through all blahs (including the two in blahblah). So the initial jump is incorrect.

Vim

VSCodeVim
Note how it jumps to the last occurrence on either * or #. This is master (not my branch). I haven't fixed this specific problem.

I think I should review these few test cases and make sure they can't trigger false positives (and add more coverage for these commands). I need to fix other broken tests as well so I can look into this at the same time (or open a separate issue).

[johnfn]

Yeah - this behavior actually works correctly on my machine. So I feel like we're dealing with some config oddities rather than actual bugs. (I do remember covering this case many many months ago...)

I'm okay with your solution, which feels nice, but I would like to know what exactly went wrong...

[rhys-vdw]

Hm. Yeah, that is weird. You did mention that and I had assumed at the time that you had misunderstood my report (since the code itself didn't seem to handle the correct behaviour). Even if I completely clear my config this still behaves as reported in #1266, so perhaps you have some configuration that is causing it to do the right thing?

Could you confirm whether you get the incorrect initial move with * and # that I show in the second gif above?

[johnfn]

Oh yeah good point. My Vim related settings are:

    "vim.useCtrlKeys": true,
    "vim.useSolidBlockCursor": false,
    "vim.timeout": 1000,
    "vim.easymotion": true,
    "vim.showcmd": true,
    "vim.otherModesKeyBindings": [ ],

[rhys-vdw]

Using your configuration made no difference.

[rhys-vdw]

@johnfn Okay, I've added tests, fixed all the problems I identified, and removed the duplication between commands. There's more information in the commit messages.

Locally all tests pass. The failures here seem to also be present in master.

[johnfn]

Great! I have been noticing weirdness with the tests as well - sorry if that was confusing.

Thanks again for the PR.