Delete Right when user presses x #122
Conversation
sharpoverride
force-pushed
the
feature/delete-right
branch
from
128947f
to
1431510
Compare
|
All are tests are here: https://github.com/VSCodeVim/Vim/tree/master/test. We currently don't have any that test normal mode commands as we are in the process of refactoring it all to better handle commands. |
| @@ -26,7 +26,7 @@ export default class NormalMode extends Mode { | |||
| "dd" : () => { return vscode.commands.executeCommand("editor.action.deleteLines"); }, | |||
| "dw" : () => { return vscode.commands.executeCommand("deleteWordRight"); }, | |||
| "db" : () => { return vscode.commands.executeCommand("deleteWordLeft"); }, | |||
| // "x" : () => { this.CommandDelete(1); } | |||
| "x" : () => { return vscode.commands.executeCommand("deleteRight"); }, | |||
There was a problem hiding this comment.
Tbh, this will likely get refactored in the future to better handle things like 4x hence the CommandDelete implementation.
There was a problem hiding this comment.
Yeah, I expect that to happen, but I need to have small things like x, or cw available in the meantime. Also I'll probably try to add some dumb visual selection. I don't use all of what vim offers, mostly stuff I got used to.
I can deploy manually for myself if you think it's better to wait for the proper handling implementation.
There was a problem hiding this comment.
Or...you can help with the proper handling implementation ;)
|
Ok, next time I'll make sure I don't change the version. thx As per your comment with multi-motion I need to find some time to think about how to go about it. Or is there a document that has some details about the approach you or somebody else expects to have? |
Small change to invoke deleteRight command when you press x.
BTW, are there any tests around the normal mode keys handling. I admit I'm still looking around and trying to add the small things that I feel productive with.