Implements Global state #1179
Implements Global state #1179
Conversation
|
Wow, very impressive work! |
| * Caveat: Use only it tests. This promise does not timeout. Awaiting this promise | ||
| * in extension code is dangerous | ||
| */ | ||
| export async function waitForTabChange(): Promise<void> { |
There was a problem hiding this comment.
Thank you :)
| @@ -124,6 +121,41 @@ export class VimState { | |||
| public currentFullAction: string[] = []; | |||
|
|
|||
| /** | |||
| * Getters and setters for changing global state | |||
| */ | |||
| public get searchStatePrevious(): SearchState[]{ | |||
There was a problem hiding this comment.
Instead of adding a bunch of shims for global state, can we just move these directly onto the globals object and allow consumers to use these getters/setters directly?
There was a problem hiding this comment.
So instead of saying vimState.searchState they would say vimState.globalState.searchState?
There was a problem hiding this comment.
Yeah, I think that makes sense. Will do
|
Minor request and we should be good to go here! |
| // import * as vscode from 'vscode'; | ||
| import { SearchState } from './searchState'; | ||
| import { RecordedState } from '../mode/modeHandler'; | ||
| // import { Position } from './../motion/position'; |
There was a problem hiding this comment.
can remove unused imports here
| @@ -30,6 +30,23 @@ export async function waitForCursorUpdatesToHappen(): Promise<void> { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * FOR TESTING PURPOSES ONLY | |||
There was a problem hiding this comment.
if you want you can add a guard to use if Globals.isTesting is set to true, not a big deal
|
Thanks again for the awesome work. |
|
And tests! |
Holds state of repeat "." actions and search globally (across editors), and added tests for each in their respective test files.
Should fix #1081 and #1156 issues