Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1013 #1014

Merged
merged 3 commits into from
Oct 31, 2016
Merged

fixes #1013 #1014

merged 3 commits into from
Oct 31, 2016

Conversation

xconverge
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@johnfn
Copy link
Member

johnfn commented Oct 30, 2016

How come we have to special case this only for visual mode?

@xconverge
Copy link
Member Author

Compare vi) to ci)

With visual, if the cursor is here|) the ) is also selected. However if we did ci) the full word here would be removed and the ) would be left(which is what we want)

@rebornix rebornix merged commit d0c3592 into VSCodeVim:master Oct 31, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants