Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:wq doesn't work when there are changes (does nothing) #613

Closed
Mehuge opened this issue Aug 15, 2016 · 1 comment
Closed

:wq doesn't work when there are changes (does nothing) #613

Mehuge opened this issue Aug 15, 2016 · 1 comment

Comments

@Mehuge
Copy link

Mehuge commented Aug 15, 2016


Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.


What did you do?

:wq<CR>

What did you expect to happen?

:wq<CR> should perform a :w then a :q

If I :w first (to save changes) or if no changes have been made, then :wq does quit

What happened instead?

nothing at all, changes not saved, editor window not closed

Technical details:

  • VSCode Version: 1.4.0
  • VsCodeVim Version: 0.1.7
  • OS: Windows
johnfn pushed a commit that referenced this issue Aug 28, 2016
* Fix bug #613

* fixed bug when closing untitled file

* make WriteCommand.Execute a async
needed to fs.accessSync to return the saving promise

* make use of Write- and QuitCommand

* fs.access - error not handled correctly

* make 'w', 'q' and 'wq' async

* created writequit test

* extract polling for vscode into function

* removed unused imports
@johnfn
Copy link
Member

johnfn commented Sep 6, 2016

It works now! :) Thanks @Platzer!

@johnfn johnfn closed this as completed Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants