[Engineering] Tab Size or Spaces

[rebornix]

This is about the code we write. I'm seeing different styles about tab or space. In some files we are using two spaces indentation but in others we are using four spaces. Or even sometimes we see Tab instead of soft Tab.

We have several more active contributors in this near week so I'm thinking that we might need put Tab/Space stuff into the Style Guide.

When we write VS Code, we use Tab instead of space but personally I prefer space. It's up you :)

[ascandella]

I've also been tripped up on this in this project. Hopefully once settled we can also enforce this in travis :)

[jpoon]

Spaces for me. I even added a gulp task fix-whitespace that should have been converting the tabs to spaces on -- I guess this isn't working?

[ascandella]

I haven't noticed any hard tabs myself, but definitely inconsistency
between 2 and 4 spaces
On Fri, Jul 15, 2016 at 8:57 PM Jason Poon [email protected] wrote:

Spaces for me. I even added a gulp fix-whitespace that should have been
converting the tabs to spaces on -- I guess this isn't working?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#457 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAF7P-_p2xiMRvimMNTy8WGQ-g98g0EEks5qWFa4gaJpZM4JN6Ap
.

[jpoon]

Unfortunately, TSLint does not yet have this capability (palantir/tslint#581).

But IMO, 2 spaces :)

[johnfn]

Probably my fault! I'm not very sensitive to differences in spacing. PRs welcomed from anyone who wants to convert the project uniformly to 2 space tabs.

[rebornix]

Fixed by #460 and I add this config to Workspace setting then no one will get it wrong.

The funny thing is, we are using 2 space tab in action.ts but 4 space tab in almost all others.

[jpoon]

Added a couple more configs to the workspace setting: 33e5290

[jpoon]

I think we're good here. Closing this issue. Thanks for the fix @rebornix.