Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Searching for:' not showing actual search string #2261

Closed
evenfrost opened this issue Jan 4, 2018 · 5 comments · Fixed by #2262
Closed

'Searching for:' not showing actual search string #2261

evenfrost opened this issue Jan 4, 2018 · 5 comments · Fixed by #2262

Comments

@evenfrost
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

What happened:
When searching with /, VSCode status bar shows --SEARCH IN PROGRESS-- Searching for: but doesn't show string currently being searched.

What did you expect to happen:
Bottom bars shows string entered for search.

How to reproduce it (as minimally and precisely as possible):
sample-search

Environment:

  • Extension (VsCodeVim) version: Sunny Seattle
  • VSCode version: 1.19.1
  • OS version: Ubuntu 17.10
@jpoon
Copy link
Member

jpoon commented Jan 4, 2018

Hm, sounds like a regression.

@intijk
Copy link

intijk commented Jan 4, 2018

I confirm this bug.

By the way, is there any way to remove the display of

--NORMAL MODES-- to nothing

and

--SEARCH IN PROGRESS-- Searching for: to a simple / ?

The long string output looks really ugly and distracting.

@jpoon
Copy link
Member

jpoon commented Jan 5, 2018

@intijk the regression has been fixed in master. I agree with you on the search in progress thing and was thinking of changing it -- thanks for validating that.

For the other part of your question, https://github.com/VSCodeVim/Vim#vimshowmodename

@intijk
Copy link

intijk commented Jan 5, 2018

Glad to see your fast integration! I saw the change in the code-insiders now.

How about simplify the display further and make it more 'vim'

  1. in normal mode, display nothing
  2. in other mode , remove 'mode' word, -- INSERT -- instead of -- INSERT MODE --
  3. I don't know if this possible, but good to have, that is to make the ':' mode also display content on bottom, instead of display a floating command window.

@jpoon
Copy link
Member

jpoon commented Jan 5, 2018

saw the change in the code-insiders now.

It doesn't matter what vscode you are running. I shipped out a new version last night so that's probably why you see it.

  1. in normal mode, display nothing

I'd prefer to keep -- NORMAL -- as that's an indication that the vim extension is loaded, and also prevents any vim beginner-eque questions about "what mode am i in?"

  1. in other mode , remove 'mode' word, -- INSERT -- instead of -- INSERT MODE --

Yeah, agreed.

  1. I don't know if this possible, but good to have, that is to make the ':' mode also display content on bottom, instead of display a floating command window.

Not do-able. there's an existing issue somewhere in our issue list about this, but it's reliant on VSCode APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants