Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extension completely breaks the Select All Occurrences command #1312

Closed
RodrigoRoaRodriguez opened this issue Feb 18, 2017 · 0 comments
Closed

Comments

@RodrigoRoaRodriguez
Copy link

RodrigoRoaRodriguez commented Feb 18, 2017

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.


This extension breaks the command in insert mode

What did you do? (Version 1)

test testit testworks testproperly
In insert mode selected test with the mouse, either click on Select All Occurrences in the menu bar or use the shortcut(cmd-shift-l then press backspace.

What did you do? (Version 2)

test testit testworks testproperly
In insert mode place the cursor at the start of the line, then either click on Select All Occurrences in the menu bar or use the shortcut then press backspace.

What did you expect to happen?

| |it |works |properly
Cursors are represented as pipes.

What happened instead?

Undefined (behaves inconsistently and unpredictably random)
All the following have occurred:
|s test|properly
test|works test|properly
|works test|properly
| test|it test|works test|properly
test| test|it test|works test|properly

However unlike Add Next Occurrence, which is also broken, cursors other than the first may or might not be bugged.

Technical details:

  • VSCode Version: 1.9.1
  • VsCodeVim Version: 0.5.3
  • OS: MacOS 10.12

Needless to say, all of the above work properly and consistently with the extension disabled.

I am aware that it also does not work in visual mode. But that is a part of this extension and it world require additional implementation to get it to work.

I am pointing out this issue because an extension should not break functionality present in the stand-alone base product. (BTW I am aware of the gc command, and it is one of of the friendliest multi-cursor implementations for modal-editing that I have encountered so far. Unfortunately, it does not do everything that I need it to do).

@RodrigoRoaRodriguez RodrigoRoaRodriguez changed the title Bug: This extension completely breaks the Select All Occurrences command This extension completely breaks the Select All Occurrences command Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant