Skip to content

PyInstaller: ビルドドキュメントでPyInstallerを使うようにする#505

Merged
Hiroshiba merged 2 commits intoVOICEVOX:pyinstallerfrom
y-chan:feature/pyinstaller-readme
Nov 6, 2022
Merged

PyInstaller: ビルドドキュメントでPyInstallerを使うようにする#505
Hiroshiba merged 2 commits intoVOICEVOX:pyinstallerfrom
y-chan:feature/pyinstaller-readme

Conversation

@y-chan
Copy link
Copy Markdown
Member

@y-chan y-chan commented Nov 6, 2022

内容

題の通り。
ただ、今までのビルドドキュメントはcuda関連ファイルもinclude-data-file引数で渡していたのに対し、今のCIではln -sなどを駆使してコピーしているので、CIとビルドドキュメントが不釣り合いになっていて、できる成果物が違っているので、そこに関する注釈などを書くべきかもしれない...?

関連 Issue

ref #439

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 6, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 129 6 coverage-95%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1237 262 coverage-79%

@Hiroshiba
Copy link
Copy Markdown
Member

PRありがとうございます!!

たしかにREADMEでビルドできるのとReleaseにあるものはかなり乖離してますね・・・。VOICEVOX RESOURCEとかも。
Releaseで配布しているものと一部異なることを軽く書いても良いかもですね!

@y-chan
Copy link
Copy Markdown
Member Author

y-chan commented Nov 6, 2022

いい感じの文が思いつかなかったですが、とりあえずの文を入れてみました。
もう少しいい感じの文があれば、置き換えてもらえると助かります...!

Copy link
Copy Markdown
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

コメント内容、良いと思います!

Copy link
Copy Markdown
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

コメント内容、良いと思います!

@Hiroshiba Hiroshiba merged commit 3f35ffd into VOICEVOX:pyinstaller Nov 6, 2022
y-chan added a commit to SHAREVOX/sharevox_engine that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants