Skip to content

[PyInstaller] Linuxビルドがうまく動かない問題を修正#468

Merged
aoirint merged 1 commit intoVOICEVOX:pyinstallerfrom
SHAREVOX:feature/fix-linux-rpath
Sep 21, 2022
Merged

[PyInstaller] Linuxビルドがうまく動かない問題を修正#468
aoirint merged 1 commit intoVOICEVOX:pyinstallerfrom
SHAREVOX:feature/fix-linux-rpath

Conversation

@y-chan
Copy link
Copy Markdown
Member

@y-chan y-chan commented Sep 10, 2022

内容

libonnxruntime_providers_cuda.solibcublas.so.8などの共有ライブラリの依存を解決できず、Linuxで動かない場合があるようで、それを解決するためにpatchelfを使ってリンクするようにしました(同じディレクトリにある共有ライブラリをリンク対象とするようにrpathを設定した)。

関連 Issue

@y-chan y-chan changed the title Linuxビルドがうまく動かない問題を修正 [PyInstaller] Linuxビルドがうまく動かない問題を修正 Sep 10, 2022
@github-actions
Copy link
Copy Markdown

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 199 159 coverage-20%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 48 39 coverage-19%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 66 9 coverage-86%
voicevox_engine/user_dict.py 131 10 coverage-92%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1203 248 coverage-79%

@qwerty2501gl
Copy link
Copy Markdown
Contributor

これcoreにも対応必要そうですね・・・

Copy link
Copy Markdown
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@aoirint さんのレビューも頂けるととても心強いです 🙇‍♂️

Copy link
Copy Markdown
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! レビュー遅くなりました!
Nuitkaでは単純にコピーして追加するだけで動いていたと思うので、NuitkaとPyInstallerで実行ファイル起動周りの仕様が違うのでしょうか...?

@aoirint aoirint merged commit a3deaa7 into VOICEVOX:pyinstaller Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants