[PyInstaller] Linuxビルドがうまく動かない問題を修正#468
Merged
aoirint merged 1 commit intoVOICEVOX:pyinstallerfrom Sep 21, 2022
Merged
Conversation
Contributor
|
これcoreにも対応必要そうですね・・・ |
Hiroshiba
approved these changes
Sep 11, 2022
aoirint
approved these changes
Sep 21, 2022
Member
aoirint
left a comment
There was a problem hiding this comment.
LGTM! レビュー遅くなりました!
Nuitkaでは単純にコピーして追加するだけで動いていたと思うので、NuitkaとPyInstallerで実行ファイル起動周りの仕様が違うのでしょうか...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
libonnxruntime_providers_cuda.soがlibcublas.so.8などの共有ライブラリの依存を解決できず、Linuxで動かない場合があるようで、それを解決するためにpatchelfを使ってリンクするようにしました(同じディレクトリにある共有ライブラリをリンク対象とするようにrpathを設定した)。関連 Issue