LinuxビルドをPyInstallerへ移行し、他OSとビルドジョブを統合する #450
Merged
y-chan merged 18 commits intoVOICEVOX:pyinstallerfrom Aug 15, 2022
Merged
Conversation
Member
|
nvidia機でLinuxを使っています。 確認すべき箇所がよくわかりませんが、単純に短いテキストをsynthesisする分には |
Member
|
長文を入れても大丈夫でした。 |
Member
Author
|
|
Hiroshiba
reviewed
Aug 14, 2022
Member
Hiroshiba
left a comment
There was a problem hiding this comment.
とても見通しが良くなったと思います、素晴らしいです!!!!
Member
Author
|
コメント頂いた件適用してみました...! |
Member
|
LGTM!! 更に見通しが上がりましたね・・・! dockerに関してはいかがでしょう?👀 |
Member
Author
|
Dockerの方も取り掛かりたいですね...! とりあえずこちらのPRはマージしてしまいますね! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
題の通り
一応CPU版の動作確認はしましたが、持っている機器の関係上GPUが正常に使えるか確認できていません。
以下にGitHub Actions上でビルドしたものをGoogle Driveに上げておいた(GitHub ActionsのArtifactsは他人は確認できないため)ので、どなたか確認していただけると助かります。
https://drive.google.com/file/d/1d6JXgowXtv-5RUbmtuWt6rhdDr8INTcc/view?usp=sharing
関連 Issue
ref #439
スクリーンショット・動画など
Artifacts自体は300MBぐらい軽量化できました
ビルド時間は全体で10分程度になっています
