VERSION.txtを消去し、releaseビルド時に自動的にバージョン名が入るようにした#288
Merged
PickledChair merged 3 commits intomasterfrom Jan 15, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 1701825846
💛 - Coveralls |
Member
Author
|
release作成しました。 windows-cpuでバージョン名が入っていることを確認しました。 |
aoirint
approved these changes
Jan 15, 2022
Member
aoirint
left a comment
There was a problem hiding this comment.
LGTM!
release.tag_nameをquoteしたい気もしますが、いい方法がわからないです...
This was referenced Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
voicevox_engine/__init__.pyにバージョン情報を記載関連 Issue
close #274
その他
npmのpackage.jsonのversionのような高尚な仕組みが見当たらなかったので、ソースコードに直書きし、sedで置き換える設計にしました。