疑問文の仕様変更反映 #272 by qwerty2501 · Pull Request #273 · VOICEVOX/voicevox_engine

qwerty2501 · 2022-01-06T14:48:16Z

内容

AccentPhraseにis_interrogativeをもたせる
疑問符Mora追加を調整前ではなく調整後に行うようにした疑問文フラグをAccentPhraseModelに持たせるように仕様変更する #272 (comment)
APIが動かなくなるため audio_query時に？が母音に置き換わるとaquestalk時モードのaccent_phrasesで疑問系に対応できない #253 の修正をここに統合

スクリーンショット・動画など

accent_phraseのis_interrogativeがない状態でrequestしてもエラーにならないことの確認

その他

coveralls · 2022-01-06T14:50:05Z

Pull Request Test Coverage Report for Build 1671319529

18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 86.633%

Totals
Change from base Build 1656060838:	0.08%
Covered Lines:	687
Relevant Lines:	793

💛 - Coveralls

github-actions · 2022-01-06T14:51:36Z

Coverage Result

Resultを開く

Name	Stmts	Miss
voicevox_engine/init.py	0	0
voicevox_engine/acoustic_feature_extractor.py	85	0
voicevox_engine/dev/synthesis_engine/init.py	2	0
voicevox_engine/dev/synthesis_engine/mock.py	29	0
voicevox_engine/full_context_label.py	167	5
voicevox_engine/kana_parser.py	89	1
voicevox_engine/model.py	71	7
voicevox_engine/mora_list.py	4	0
voicevox_engine/preset/Preset.py	12	0
voicevox_engine/preset/PresetLoader.py	34	1
voicevox_engine/preset/init.py	3	0
voicevox_engine/synthesis_engine/init.py	5	0
voicevox_engine/synthesis_engine/forwarder.py	76	66
voicevox_engine/synthesis_engine/make_synthesis_engine.py	23	18
voicevox_engine/synthesis_engine/synthesis_engine.py	107	0
voicevox_engine/synthesis_engine/synthesis_engine_base.py	49	5
voicevox_engine/utility/init.py	2	0
voicevox_engine/utility/connect_base64_waves.py	35	3
TOTAL	793	106

test/test_synthesis_engine_base.py

voicevox_engine/synthesis_engine/synthesis_engine_base.py

- AccentPhraseにis_interrogativeをもたせる - 疑問符Mora追加を調整前ではなく調整後に行うようにした VOICEVOX#272 (comment) refs VOICEVOX#272

qwerty2501 · 2022-01-06T15:11:21Z

is_kana時の/accent_phraseが上手く動かなくなるので #255 の修正内容もこっちで行う

/accent_phrases時にis_kanaがtrueだとInternal Server errorが発生するようになったため、 VOICEVOX#255 での修正をこっちに統合した refs VOICEVOX#253,VOICEVOX#255

test/test_synthesis_engine_base.py

Hiroshiba · 2022-01-07T19:08:22Z

ディスカッションがあったのですが、 #272 (comment) のとおり結論が出たので、アサインしてみます！

voicevox_engine/kana_parser.py

VOICEVOX#273 (comment)

takana-v

LGTM！

test/test_synthesis_engine_base.py

aoirint

LGTM！コードは問題なさそうでした！

qwerty2501 commented Jan 6, 2022

View reviewed changes

test/test_synthesis_engine_base.py Show resolved Hide resolved

voicevox_engine/synthesis_engine/synthesis_engine_base.py Show resolved Hide resolved

疑問文の仕様変更反映 VOICEVOX#272

6f6283a

- AccentPhraseにis_interrogativeをもたせる - 疑問符Mora追加を調整前ではなく調整後に行うようにした VOICEVOX#272 (comment) refs VOICEVOX#272

qwerty2501 force-pushed the feature/add_is_interrrogative_to_accent_phrase branch from 7d4eb98 to 6f6283a Compare January 6, 2022 14:58

qwerty2501 mentioned this pull request Jan 6, 2022

create_kanaを疑問文に対応してaudio_query時に？が母音に書き換わってしまうのを抑止するようにした #255

Closed

create_kanaを疑問文に対応 VOICEVOX#253

04eed50

/accent_phrases時にis_kanaがtrueだとInternal Server errorが発生するようになったため、 VOICEVOX#255 での修正をこっちに統合した refs VOICEVOX#253,VOICEVOX#255

qwerty2501 marked this pull request as ready for review January 6, 2022 15:42

qwerty2501 mentioned this pull request Jan 7, 2022

疑問文フラグをAccentPhraseModelに持たせるように仕様変更する #272

Closed

Hiroshiba reviewed Jan 7, 2022

View reviewed changes

test/test_synthesis_engine_base.py Outdated Show resolved Hide resolved

Hiroshiba requested review from Hiroshiba, aoirint and takana-v January 7, 2022 19:08

printが入っていたので消した

0542fb0

takana-v suggested changes Jan 8, 2022

View reviewed changes

voicevox_engine/kana_parser.py Show resolved Hide resolved

末尾がptich0でcreate_kanaすると？がつけられてしまうので修正

9916cfc

VOICEVOX#273 (comment)

takana-v approved these changes Jan 8, 2022

View reviewed changes

test/test_synthesis_engine_base.py Show resolved Hide resolved

aoirint approved these changes Jan 10, 2022

View reviewed changes

aoirint merged commit 5496881 into VOICEVOX:master Jan 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

疑問文の仕様変更反映 #272#273

疑問文の仕様変更反映 #272#273
aoirint merged 4 commits intoVOICEVOX:masterfrom
qwerty2501:feature/add_is_interrrogative_to_accent_phrase

qwerty2501 commented Jan 6, 2022 •

edited

Loading

Uh oh!

coveralls commented Jan 6, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jan 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

qwerty2501 commented Jan 6, 2022

Uh oh!

Uh oh!

Hiroshiba commented Jan 7, 2022

Uh oh!

Uh oh!

takana-v left a comment

Uh oh!

Uh oh!

aoirint left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

qwerty2501 commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

内容

関連 Issue

スクリーンショット・動画など

その他

Uh oh!

coveralls commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 1671319529

💛 - Coveralls

Uh oh!

github-actions bot commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Result

Uh oh!

Uh oh!

Uh oh!

qwerty2501 commented Jan 6, 2022

Uh oh!

Uh oh!

Hiroshiba commented Jan 7, 2022

Uh oh!

Uh oh!

takana-v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aoirint left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

qwerty2501 commented Jan 6, 2022 •

edited

Loading

coveralls commented Jan 6, 2022 •

edited

Loading

github-actions bot commented Jan 6, 2022 •

edited

Loading