Revert "refactor: data modelを分離 (#256)"#266
Merged
Hiroshiba merged 1 commit intoVOICEVOX:masterfrom Jan 4, 2022
Merged
Conversation
This reverts commit ff00ad6.
Pull Request Test Coverage Report for Build 1653597114
💛 - Coveralls |
Hiroshiba
approved these changes
Jan 4, 2022
Member
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM!!
revertの発想はなかったです、良いと思います!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
This reverts commit ff00ad6.
0.10.preview.8のエンジンが起動しない問題を解決するために一旦 #256 をrevertします。
別でどのように実装しなおすか検討するIssueまたはPRを立てる必要があるかもしれません。
重複を避けるため立てる場合は @qwerty2501 さんにお願いしたいです。
関連 Issue
close #264