Skip to content

Revert "refactor: data modelを分離 (#256)"#266

Merged
Hiroshiba merged 1 commit intoVOICEVOX:masterfrom
takana-v:revert-#256
Jan 4, 2022
Merged

Revert "refactor: data modelを分離 (#256)"#266
Hiroshiba merged 1 commit intoVOICEVOX:masterfrom
takana-v:revert-#256

Conversation

@takana-v
Copy link
Member

@takana-v takana-v commented Jan 4, 2022

内容

This reverts commit ff00ad6.
0.10.preview.8のエンジンが起動しない問題を解決するために一旦 #256 をrevertします。

別でどのように実装しなおすか検討するIssueまたはPRを立てる必要があるかもしれません。
重複を避けるため立てる場合は @qwerty2501 さんにお願いしたいです。

関連 Issue

close #264

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1653597114

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 86.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
voicevox_engine/model.py 5 6 83.33%
Totals Coverage Status
Change from base Build 1645757998: -0.9%
Covered Lines: 690
Relevant Lines: 798

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 30 1 coverage-97%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 87 1 coverage-99%
voicevox_engine/model.py 70 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 76 66 coverage-13%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 23 18 coverage-22%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 55 6 coverage-89%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 798 108 coverage-86%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

revertの発想はなかったです、良いと思います!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.10.preview.8のエンジンが起動しない

3 participants