feat(e2k): kanalizerに移行#1694
Conversation
|
enable_e2kフラグに関してこのコメントから引用まで 🙏
|
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the text-to-speech pipeline from using e2k to using kanalizer for converting unknown English words to katakana. Key changes include replacing e2k with kanalizer in katakana_english.py, updating license information, and removing e2k dependency references from run.spec, requirements, and pyproject.toml.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| voicevox_engine/tts_pipeline/katakana_english.py | Replace e2k conversion with kanalizer and update error fallback logic |
| tools/generate_licenses.py | Remove e2k license URL |
| run.spec | Remove e2k data files collection |
| requirements-dev.txt | Remove e2k dependency and add kanalizer dependency |
| requirements-build.txt | Remove e2k dependency and add kanalizer dependency |
| pyproject.toml | Remove e2k dependency and add kanalizer dependency |
Comments suppressed due to low confidence (1)
voicevox_engine/tts_pipeline/katakana_english.py:68
- [nitpick] The variable name 'add_alphabet_yomi' could be more descriptive, for example, 'use_fallback_conversion', to better indicate that it triggers the fallback conversion path.
add_alphabet_yomi = False
tarepan
left a comment
There was a problem hiding this comment.
👍️
新ライブラリ導入により高い精度の読み推定が期待されます。ユーザーの声が楽しみですね!
🤔
CI が落ちています。
内容は「Voivo を ボ'イボ と読んでいたものが ヴォ'イヴォ と読まれるように変わった」というものです。
e2k 導入に伴いアルファベットの読みが変換したものであり、特段問題ないと考えます。
これを解決するため、snapshot 更新が必要です。CONTRINBUTING.md に手順があります。
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the text conversion and license management from the e2k dependency to kanalizer. Key changes include:
- Replacing e2k import and usage with kanalizer in text conversion.
- Updating test snapshots and expected output strings to reflect the new conversion.
- Adjusting license generation scripts and dependencies to remove e2k and add kanalizer.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| voicevox_engine/tts_pipeline/katakana_english.py | Updated dependency and conversion logic to use kanalizer. |
| tools/generate_licenses.py | Removed e2k license info and patched license info for kanalizer. |
| test/unit/tts_pipeline/test_katakana_english.py | Updated expected output for the new conversion. |
| test/e2e/single_api/tts_pipeline/snapshots/test_audio_query/test_post_audio_query_enable_e2k_200.json | Updated snapshot data for conversion changes. |
| test/e2e/single_api/tts_pipeline/snapshots/test_accent_phrases/test_post_accent_phrases_enable_e2k_200.json | Updated snapshot data for conversion changes. |
| run.spec | Removed data collection for e2k. |
| requirements-dev.txt, requirements-build.txt, pyproject.toml | Removed e2k dependency and added kanalizer. |
tarepan
left a comment
There was a problem hiding this comment.
LGTM!
_patch_licenses_manually() により自動差し替え(_update_licenses())と区別したのも良い実装だと感じます。
実利用が楽しみです!
Co-authored-by: takana-v <44311840+takana-v@users.noreply.github.com>
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM!!
楽しみですね!!!!!
マージ後ビルドしてみます!!
内容
e2kをkanalizerにします。
関連 Issue
スクリーンショット・動画など
(なし)
その他
(なし)