TypeScriptを更新 #959
Merged
TypeScriptを更新 #959
+5,347
−3,808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MT224244
commented
Sep 28, 2022
| "@vue/test-utils": "2.0.0-rc.6", | ||
| "chai": "4.3.4", | ||
| "chai-as-promised": "7.1.1", | ||
| "electron": "19.0.6", | ||
| "electron-devtools-installer": "3.2.0", | ||
| "eslint": "6.8.0", | ||
| "eslint": "8.24.0", | ||
| "eslint-config-prettier": "8.5.0", |
There was a problem hiding this comment.
eslint-plugin-prettierのバージョンを更新したことで要求されるようになったので新しく追加しています。
prettier/eslint-plugin-prettier#253 (comment)
There was a problem hiding this comment.
これ、eslint-plugin-prettierを更新したわけではなく、@vue/eslint-config-prettierを更新した結果、依存しているeslint-plugin-prettierのバージョンが上がった、が正しかったです。
|
なんというか、すごくどっちでも良いですね･･･。 |
|
テスト通ってそうなのでDraft外します！ |
y-chan
approved these changes
Oct 2, 2022
yamachu
approved these changes
Oct 2, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
TypeScriptのバージョンをv4.8.4に更新します。
それに伴い出た警告を解消するためにeslint系の依存関係も更新しています。
また、新たに出た型エラーやリンターエラーの修正も含まれます。
vue/multi-word-component-names だけまだ残っていますが、これに関しては @Hiroshiba さんの意見を伺いたいのであえて残しています。
個人的にはこのルールは設定で切ってしまってもいいかなと思っています。
関連 Issue