Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 開発実行・ビルド時にvite-plugin-checkerでlintを実行しないようにする #2516

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 31, 2025

内容

の解決PRです。

開発時にelectron:serve等で実行するたびになかなか重たいので、vite-plugin-checkerでeslintを走らせないようにします。
型チェックは有用(発見が遅れると手戻りがすごいことがある・気付けないことも多い)なのと、そんなに重くないので残します。
CPU計測結果はこちら

関連 Issue

fix: #2515

その他

Discordでのコメント
https://discordapp.com/channels/879570910208733277/893889888208977960/1334812766946459721

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 31, 2025 09:53
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題はなさそう。

@Hiroshiba Hiroshiba requested a review from Copilot January 31, 2025 09:55
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:45a407a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Hiroshiba
Copy link
Member Author

ありがとうございます、マージします!

@Hiroshiba Hiroshiba enabled auto-merge January 31, 2025 09:55
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 31, 2025
Merged via the queue into VOICEVOX:main with commit 7b4cb60 Jan 31, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the hiho-20250131-185255 branch January 31, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ビルドや実行時のvite-plugin-checkerをなくしても良いかも?
2 participants