-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: createLoggerを拡張してelectron側からもフロントエンド側からも使えるように #2491
The head ref may contain hidden characters: "feat--electron\u7528\u306Elogger\u4F5C\u6210"
Conversation
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
タイトルが進行途中感あるものになってしまっていたので、完成してることがわかるタイトルに変えました 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/components/Dialog/HelpDialog/HelpDialog.vue: Evaluated as low risk
- src/domain/frontend/log.ts: Evaluated as low risk
- src/components/Talk/AudioInfo.vue: Evaluated as low risk
- src/components/Sing/SequencerRuler/Presentation.vue: Evaluated as low risk
- src/components/Sing/SequencerPitch.vue: Evaluated as low risk
- src/components/Sing/ScoreSequencer.vue: Evaluated as low risk
- src/components/Dialog/SettingDialog/SettingDialog.vue: Evaluated as low risk
- src/components/Dialog/ImportSongProjectDialog.vue: Evaluated as low risk
- src/backend/electron/portHelper.ts: Evaluated as low risk
- src/backend/electron/manager/engineInfoManager.ts: Evaluated as low risk
- src/backend/browser/fileImpl.ts: Evaluated as low risk
- src/backend/electron/fileHelper.ts: Evaluated as low risk
- src/backend/electron/engineAndVvppController.ts: Evaluated as low risk
- src/backend/electron/main.ts: Evaluated as low risk
- src/backend/electron/manager/RuntimeInfoManager.ts: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそう。
内容
createLoggerを拡張し、electron側からもフロントエンド側からも使えるようにしました。
#2489 (comment) を参考にしています。
logger
という名前にしようとしましたが、一旦差分ができる限り少なくなるようにlog
にしました。コードによって
log
だったりlogger
だったり展開構文使ってたりなので、全部loggerに統一してもいいかも。その他
.log
を.info
に置き換えています。log
のログレベルがよくわからない(javascript以外にない気がする?)ので、まあinfoにしちゃって良いかなと・・・!