Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createLoggerを拡張してelectron側からもフロントエンド側からも使えるように #2491

Merged
merged 7 commits into from
Jan 19, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Jan 17, 2025

内容

createLoggerを拡張し、electron側からもフロントエンド側からも使えるようにしました。
#2489 (comment) を参考にしています。

loggerという名前にしようとしましたが、一旦差分ができる限り少なくなるようにlogにしました。
コードによってlogだったりloggerだったり展開構文使ってたりなので、全部loggerに統一してもいいかも。

その他

.log.infoに置き換えています。
logのログレベルがよくわからない(javascript以外にない気がする?)ので、まあinfoにしちゃって良いかなと・・・!

  • 実際にビルドされたソフトウェアのログがちゃんとタイムスタンプとかが書かれてるかどうかチェック

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 17, 2025 15:23
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Jan 17, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:2a792b3

@Hiroshiba Hiroshiba changed the title feat: electron用のlogger作成途中 feat: createLoggerを拡張してelectron側からもフロントエンド側からも使えるように Jan 18, 2025
@Hiroshiba
Copy link
Member Author

タイトルが進行途中感あるものになってしまっていたので、完成してることがわかるタイトルに変えました 🙏

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • src/components/Dialog/HelpDialog/HelpDialog.vue: Evaluated as low risk
  • src/domain/frontend/log.ts: Evaluated as low risk
  • src/components/Talk/AudioInfo.vue: Evaluated as low risk
  • src/components/Sing/SequencerRuler/Presentation.vue: Evaluated as low risk
  • src/components/Sing/SequencerPitch.vue: Evaluated as low risk
  • src/components/Sing/ScoreSequencer.vue: Evaluated as low risk
  • src/components/Dialog/SettingDialog/SettingDialog.vue: Evaluated as low risk
  • src/components/Dialog/ImportSongProjectDialog.vue: Evaluated as low risk
  • src/backend/electron/portHelper.ts: Evaluated as low risk
  • src/backend/electron/manager/engineInfoManager.ts: Evaluated as low risk
  • src/backend/browser/fileImpl.ts: Evaluated as low risk
  • src/backend/electron/fileHelper.ts: Evaluated as low risk
  • src/backend/electron/engineAndVvppController.ts: Evaluated as low risk
  • src/backend/electron/main.ts: Evaluated as low risk
  • src/backend/electron/manager/RuntimeInfoManager.ts: Evaluated as low risk
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう。

@Hiroshiba Hiroshiba enabled auto-merge January 19, 2025 20:44
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 19, 2025
Merged via the queue into VOICEVOX:main with commit 7b1f36d Jan 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants