fix: ドラッグアンドドロップでプロジェクトファイルやテキストファイルが読み込めなかったのを直す #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
changed the title
Hiroshiba
commented
Dec 22, 2024
Comment on lines
-689
to
+694
| action(payload: { filePath?: string }): void; | ||
| action( | ||
| payload: | ||
| | { type: "dialog" } | ||
| | { type: "path"; filePath: string } | ||
| | { type: "file"; file: File }, | ||
| ): void; |
There was a problem hiding this comment.
filePathが指定されていなかったらダイアログが開かれる実装だったけど、ややこしいので経路を選べるようにしました。
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
force-pushed
the
ドラッグアンドドロップでプロジェクトファイルやテキストファイルが読み込めなかったのを直す
branch
from
4565d2c to
82a7c9e
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- src/components/Talk/TalkEditor.vue: Evaluated as low risk
- src/components/Talk/ToolBar.vue: Evaluated as low risk
- src/components/App.vue: Evaluated as low risk
- src/components/Menu/MenuBar/MenuBar.vue: Evaluated as low risk
- src/components/Talk/menuBarData.ts: Evaluated as low risk
- src/backend/electron/preload.ts: Evaluated as low risk
- src/plugins/ipcMessageReceiverPlugin.ts: Evaluated as low risk
- src/store/audio.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/type/ipc.ts:247
- Changing
filePathfrom optional to required might cause issues if there are any calls toLOAD_PROJECT_FILEwithout afilePath. Ensure that all calls toLOAD_PROJECT_FILEare updated accordingly.
args: [obj: { filePath: string }];
|
たぶん大丈夫だと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決プルリクエストです。
一応このプルリクエストが先に必要です。
経緯はissue側のコメントに書いています。
解決方法として、ブラウザ側に持ってこられたFileはelectronの関数を使ってパスを取得できるぽかったので、その経路を用意しました。
ブラウザの時はこの関数が使えないので、代わりにそのままFileオブジェクトを渡せるようにしました。
関連 Issue
close #2431
その他
ついでにブラウザでのドラッグ&ドロップも動くようになったはず。便利。