Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] SET_SINGER内のawait SETUP_SINGERを待機しないようにする #1891

Conversation

Hiroshiba
Copy link
Member

内容

SET_SINGER内でSETUP_SINGERを待っているのですが、これは待たなくてもいいのと、処理が重いので待たないようにしました。

その他

SETUPは必須ではなく、音声合成のリクエストを投げたら必要な初期化処理をエンジン側が行っています。
SETUPはその初期化を前もってやっておく感じです。

@Hiroshiba Hiroshiba requested a review from a team as a code owner March 2, 2024 19:32
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team March 2, 2024 19:32
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
マージしちゃいますね....!

@y-chan y-chan merged commit 36fb7f2 into VOICEVOX:main Mar 6, 2024
9 checks passed
@Hiroshiba Hiroshiba deleted the SET_SINGER内でSETUP_SINGERしてるのを解体する branch March 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants