Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-library-manage] ライブラリ管理画面のデータの持ち方などをリファクタリング #1584

Open
wants to merge 13 commits into
base: project-library-manage
Choose a base branch
from
+116 −91
Open

[project-library-manage] ライブラリ管理画面のデータの持ち方などをリファクタリング #1584

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
06a2d6b
change downloadable library type (array to object)
y-chan Sep 24, 2023
9bad347
remove "brand"
y-chan Sep 24, 2023
56f4252
fix miss
y-chan Sep 24, 2023
efd90cb
change installed library type (array to object)
y-chan Sep 24, 2023
dc06f1b
create library type and refactor
y-chan Sep 24, 2023
84ed26e
fix type miss
y-chan Sep 25, 2023
21303ae
split button by library type
y-chan Sep 28, 2023
98c1912
change downloadable to notInstalled
y-chan Sep 28, 2023
eaa9fb2
fix variable name
y-chan Sep 28, 2023
b768b86
assert in uninstall library function
y-chan Sep 28, 2023
c96f572
use map (guaranteed order)
y-chan Sep 28, 2023
73b508b
fix type error
y-chan Sep 28, 2023
1b4a0ba
add comment
y-chan Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix variable name
@y-chan
y-chan committed Sep 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit eaa9fb264396a70510f465c233e7d583779756c0
4 changes: 2 additions & 2 deletions src/components/LibraryManageDialog.vue
View file
Original file line number Diff line number Diff line change
@@ -338,7 +338,7 @@ watch(modelValueComputed, async (newValue) => {
engineInstalledLibraries,
]): LibraryType[] => {
fetchStatuses.value[engineId] = "success";
const convertedInstalledLibrary = Object.fromEntries(
const convertedInstalledLibraries = Object.fromEntries(
Object.entries(engineInstalledLibraries).map(
([uuid, library]) => {
return [
@@ -360,7 +360,7 @@ watch(modelValueComputed, async (newValue) => {
uuid: LibraryId(library.uuid),
speakers: libraryInfoToCharacterInfos(engineId, library),
};
const installedLibrary = convertedInstalledLibrary[library.uuid];
const installedLibrary = convertedInstalledLibraries[library.uuid];
if (installedLibrary) {
return {
...libraryBase,