Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用していないコードの削除 #1341

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

yamachu
Copy link
Member

@yamachu yamachu commented Jun 19, 2023

内容

ブラウザ版の作業を進めるにあたり、ブラウザ版の Sandbox の実装が必要である。
実装するためにコードの精査をしたところ、使われていないコードが見つかったため、作業量を減らすために削除する。

関連 Issue

ref #1204

スクリーンショット・動画など

その他

@yamachu yamachu requested a review from a team as a code owner June 19, 2023 16:58
@yamachu yamachu requested review from y-chan and removed request for a team June 19, 2023 16:58
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

手が空いたのでレビューしちゃいます・・・! 🙇‍♂️ @y-chan

@Hiroshiba Hiroshiba merged commit fe9168f into VOICEVOX:main Jun 19, 2023
@yamachu yamachu deleted the misc/delete-unused-sandbox branch June 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants