Refactor: src/components/Dialog.ts
の引数を変更
#1340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要
#1335 での実装では引数に
confirmedTips
を利用しており関数の役割が明確でない状態でした。今回の改修では
Dialog.ts
でconfirmedTips
を参照せずにnotifyOnGenerateAudio
を更新できるよう、SET_CONFIRMED_TIP
を作成しています。関連コメント
#1335 (comment)
変更
src/store/setting.ts
にSET_CONFIRMED_TIP
を追加src/components/Dialog.ts
内の関数で受け取る引数をnotifyOnGenerateAudio
に変更関連 Issue
ref #1329
その他
別でIssueとして上がっている
Dialog.ts
の処理共通化とは別のタスクとしてPR出しました。そのため、変更差分が内容に対して少し大きくなってしまっています。。。