-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voltaによるバージョン管理を追記 #1315
Merged
Merged
Voltaによるバージョン管理を追記 #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.node_versionとの同期を確認するワークフローを追加。
Hiroshiba
reviewed
May 17, 2023
アクションの実行タイミングの修正とminify、README.mdへの記載の追加を行いました。(アクションの読み込みが目に見えない単位で早くなったはず) |
Hiroshiba
reviewed
Jun 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
高速なのは嬉しいです!!
ほぼLGTMです!!
Hiroshiba
reviewed
Jun 7, 2023
Hiroshiba
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
チェックするワークフロー、便利だと思うのでVoltaの方に提案してみるのも面白いかも?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Voltaによるバージョン管理を追記し、また
.node_version
とVoltaでのバージョンが同期していることを確認するワークフローを追加します。関連 Issue
スクリーンショット・動画など
その他
将来的にpackage-lock.jsonの差分確認などを入れてinstallをしてしまった場合に気付けるようにしてもいいかもしれません。