Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 辞書の単語入力で全てのスペースを置換するようにする #1300 #1301

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

finict
Copy link
Contributor

@finict finict commented Apr 25, 2023

内容

辞書登録時の正規表現によるスペースのチェックで最初のみではなく全ての一致にマッチするようにしました

関連 Issue

close #1300

@finict finict requested a review from a team as a code owner April 25, 2023 22:46
@finict finict requested review from Hiroshiba and removed request for a team April 25, 2023 22:46
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

経緯がとてもわかりやすかったです、プルリクありがとうございました!!
もしよかったらまたのプルリクエストをお待ちしています…!

@Hiroshiba Hiroshiba merged commit daf6974 into VOICEVOX:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

辞書で複数のスペースを含む単語の扱いがおかしい
2 participants