Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: npm audit #1299

Closed
wants to merge 1 commit into from
Closed

Update: npm audit #1299

wants to merge 1 commit into from

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Apr 25, 2023

内容

npm audit fixをしました。起動して音声合成の挙動、オプションの表示、npm run test:unit が通るのを確認しました

関連 Issue

#1298 より先にこちらをしたほうが良いかも知れません

@raa0121 raa0121 requested a review from a team as a code owner April 25, 2023 15:05
@raa0121 raa0121 requested review from y-chan and removed request for a team April 25, 2023 15:05
y-chan
y-chan approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないと思います！
#1298 が先にマージされたので、(コンフリクトは起きてないっぽいので気にしなくていいかもですが)差分が発生している可能性を考慮してauditをやり直した方がいいかも...?と思いました

@Hiroshiba
Copy link
Member

マージ後にaudit fixした↓がマージされたのでcloseします！

@Hiroshiba Hiroshiba closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raa0121 @Hiroshiba @y-chan