Fix #1229 #1289
Merged
Fix #1229 #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chModeItemClicked
Hiroshiba
reviewed
Apr 15, 2023
Hiroshiba
approved these changes
Apr 16, 2023
|
問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
初回起動時と追加キャラクター検出された場合に起動シーケンス内で「並び替えダイアログ」が開かれるが、開かれている間にも起動シーケンス処理が進んでいき、その際に並び替えが反映される前に最初のAudioCellが作られるため初回起動時では四国めたん、追加キャラクター検出時には追加キャラクターが選択された状態になっていました。
store.state.userCharacterOrderをwatchして並び替えが反映されたタイミングでaudioCell.updateFirstCharacterを実行し、その後unwatchするようにしました。関連 Issue
close #1229
スクリーンショット・動画など
2023-04-13.20-21-31.mp4
その他