Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: e2eテストのタイムアウトの指定を修正 #1286

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix: e2eテストのタイムアウトの指定を修正 #1286

merged 1 commit into from
Apr 12, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

e2eテストで、起動が遅くタイムアウト扱いになりFlaky化してしまっていたのを修正します。

関連 Issue

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner April 12, 2023 09:31
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team April 12, 2023 09:31
Hiroshiba
Hiroshiba approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

ちなみに２回めで成功するのって、エンジンが消えてないからなのか、２回めのエンジン起動が速いからなのかどっちなんでしょう。
エンジンが消えてないならおそらく意図した挙動じゃないので、消えるようになったほうが良さそう･･･？（どうやるんだろう）

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします！

@Hiroshiba Hiroshiba closed this Apr 12, 2023
@Hiroshiba Hiroshiba reopened this Apr 12, 2023
@Hiroshiba Hiroshiba merged commit c05f9fc into VOICEVOX:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba