Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

デフォルトプリセット周りのリファクタ #1274

Merged
merged 17 commits into from
Apr 8, 2023
Merged

デフォルトプリセット周りのリファクタ #1274

merged 17 commits into from
Apr 8, 2023

Conversation

k-chop
Copy link
Contributor

@k-chop k-chop commented Apr 1, 2023

内容

で後回しにしたリファクタを行いました。
以下は上記issueのコピペです

問題一覧

補足

引数で渡したaudioItemを直接書き換えていた問題 #1228 (comment) は、「audioItemと presetItemを取ってプリセット適用済みの新しいaudioItemを返す関数」に切り出すことで解決しました。
該当コミット： 92bf9ad

関連 Issue

close #1247

@k-chop k-chop requested a review from a team as a code owner April 1, 2023 05:59
@k-chop k-chop requested review from y-chan and removed request for a team April 1, 2023 05:59
@Hiroshiba
Copy link
Member

レビューが @y-chan さんに割り当たっていますが、以前頂いたPRの記憶がある僕が担当したほうが進めやすそうなのでアサイン変えさせていただこうと思います･･･！

@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for y-chan April 2, 2023 16:59
Hiroshiba
Hiroshiba reviewed Apr 2, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的にLGTM寄りです！！

細かい点ですがいくつかコメントさせていただきました 🙇‍♂️

src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
src/store/audio.ts Outdated Show resolved Hide resolved
@k-chop k-chop changed the title デフォルトプリセット周りのリファクタ [WIP] デフォルトプリセット周りのリファクタ Apr 3, 2023
Hiroshiba
Hiroshiba reviewed Apr 4, 2023
View reviewed changes
src/store/audio.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed Apr 4, 2023
View reviewed changes
src/store/audio.ts Outdated Show resolved Hide resolved
@k-chop k-chop changed the title [WIP] デフォルトプリセット周りのリファクタ デフォルトプリセット周りのリファクタ Apr 5, 2023
@k-chop k-chop requested a review from Hiroshiba April 5, 2023 14:47
@k-chop
Copy link
Contributor Author

k-chop commented Apr 5, 2023

一通り対応できたので review re-request しておきます！よろしくお願いします🙏

Hiroshiba
Hiroshiba reviewed Apr 8, 2023
View reviewed changes
src/store/audio.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba reviewed Apr 8, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！！

リファクタリングありがとうございました、健全性が上がったと思います！！！

@Hiroshiba
Copy link
Member

リファクタリングで挙動が変わってないはず。
問題ないと思うのでマージします！

@Hiroshiba Hiroshiba merged commit c11f551 into VOICEVOX:main Apr 8, 2023
@k-chop k-chop deleted the issue1247/refactor-default-preset branch April 8, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

デフォルトプリセット周りのリファクタ
2 participants
@k-chop @Hiroshiba