build-prepackageとbuild-distributableを統合する #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Mar 5, 2023
Comment on lines
131
to
138
| # Rename executable file | ||
| # NOTE: If the CPU/DirectML/GPU builds have the same package name, | ||
| # the NSIS installers and the 7z files have duplicate names. | ||
| # For Linux, If they have the same product name, | ||
| # the AppImages have duplicate names. | ||
| # Files with the same name cannot be uploaded to a single GitHub Release, | ||
| # so different package/product names should be used for CPU/DirectML/GPU builds. | ||
| - name: Replace package name & version |
There was a problem hiding this comment.
消える箇所からコメントを転機。（このPRで消える別箇所に同じステップがある）
Hiroshiba
commented
Mar 5, 2023
Comment on lines
-361
to
+370
| mv prepackage VOICEVOX | ||
| tar cfz "${{ matrix.compressed_artifact_name }}-${{ env.VOICEVOX_EDITOR_VERSION }}.tar.gz" VOICEVOX/ | ||
| name="${{ matrix.compressed_artifact_name }}-${{ env.VOICEVOX_EDITOR_VERSION }}" | ||
| 7z a -ttar $name.tar prepackage/ | ||
| 7z rn $name.tar prepackage/ VOICEVOX/ | ||
| 7z a -tgzip $name.tar.gz $name.tar | ||
| rm $name.tar |
There was a problem hiding this comment.
元はprepackageディレクトリをVOICEVOXディレクトリと改名してzip圧縮してるが、ここ以降でprepackageディレクトリが必要になるため、zip圧縮した後にzip内でディレクトリ名を改名するロジックに変更
|
@y-chan 催促すみません！ 時間あるときに見ていただけると･･･！！ |
|
コンフリクト解消してテストも通ったのでたぶん大丈夫そう！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連のPRです。
build.ymlのbuild-prepackageジョブとbuild-distributableジョブを統合し、１つのジョブにします。
実際にビルドしてみてwindowsのzip版が動くことを確認済みです。
https://github.com/Hiroshiba/voicevox/releases/tag/0.15.2-buildtest
関連 Issue
#837
スクリーンショット・動画など
その他
あとはreleaseアップロード周りを統一すればかなり早くなる＆リファクタリングもしやすく鳴るはず！！