FIX: エンジン追加後にプロジェクトの保存をキャンセルすると同じエンジンを複数登録できてしまう問題を修正 #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Mar 1, 2023
| @@ -593,6 +601,7 @@ const requireRestart = (message: string) => { | |||
| }, | |||
| }) | |||
| .onOk(() => { | |||
| toInitialState(); | |||
There was a problem hiding this comment.
なるほどです！
onCancel側とコピペコードになっていますが、$q.dialogの仕様上仕方ないかもと思いました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
同じエンジンを重複して保存できてしまう問題を修正します。
再現方法
特に既存エンジンを重複登録すると同じエンジンを同時に起動させようとしてしまうため起動が不可能になってしまいます。
その他
ついでに型エラーを修正しておきましたがこの辺りのいい対処方法が分からなかったのでエラーのままにしています。
voicevox/src/components/EngineManageDialog.vue
Lines 280 to 285 in cb7203d