Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

プロジェクトの変更を保存するかを聞く部分を統一化 #1239

Merged
merged 2 commits into from
Mar 1, 2023
Merged

プロジェクトの変更を保存するかを聞く部分を統一化 #1239

merged 2 commits into from
Mar 1, 2023

Conversation

Hiroshiba
Copy link
Member

内容

プロジェクトの変更を破棄するかを聞く箇所は３箇所あり、その１箇所が良い感じになりました。

このPRでは処理を共通化し、残り２箇所も良い感じにします。

関連 Issue

@Hiroshiba Hiroshiba requested a review from a team as a code owner February 28, 2023 21:16
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team February 28, 2023 21:16
@Hiroshiba
Copy link
Member Author

@sabonerune @y-chan もしよかったら見てみていただけると･･･！

y-chan
y-chan approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

@sabonerune
Copy link
Contributor

自分がチェックした限り問題なさそうでした。

@Hiroshiba
Copy link
Member Author

レビューありがとうございます！　マージします！！

@Hiroshiba Hiroshiba merged commit d91ca4d into VOICEVOX:main Mar 1, 2023
@Hiroshiba Hiroshiba deleted the プロジェクトの変更を保存するかを聞く部分を統一化 branch March 1, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hiroshiba @sabonerune @y-chan