Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: e2eテストの細かい挙動を修正 #1220

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Fix: e2eテストの細かい挙動を修正 #1220

merged 2 commits into from
Feb 23, 2023

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Feb 21, 2023 •
edited
Loading

内容

e2eテストを走らせたときの細かい挙動を修正します。

  • vite-plugin-electron側でelectronを立ち上げないようにします。
  • ESLint/tscのチェックを消します。（テストが9秒くらい遅くなっている、ログが流れる、専用のscriptがある）

関連 Issue

スクリーンショット・動画など

（なし）

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner February 21, 2023 09:15
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team February 21, 2023 09:15
Hiroshiba
Hiroshiba approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

たぶん問題ないと思うのでマージします！

@Hiroshiba Hiroshiba merged commit 13a268c into VOICEVOX:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba