Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Node.jsのバージョン取得にnode-version-fileを使うように #1208

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Feb 16, 2023

内容

タイトル通り。
参照: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

これを機にNode.jsを18にあげてもいいかもしれない?

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner February 16, 2023 08:43
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team February 16, 2023 08:43
@sevenc-nanashi sevenc-nanashi changed the title Fix: Node.jsのバージョン取得を修正 Fix: Node.jsのバージョン取得にnode-version-fileを使うように Feb 16, 2023
@PickledChair
Copy link
Member

build.yml の方は、actions/setup-node があと2箇所ありそうでした……!

- name: Set output Node version
id: node-version
shell: bash
run: echo "NODE_VERSION=$(cat .node-version)" >> $GITHUB_OUTPUT
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: "${{ steps.node-version.outputs.NODE_VERSION }}"

- name: Set output Node version
id: node-version
shell: bash
run: echo "NODE_VERSION=$(cat .node-version)" >> $GITHUB_OUTPUT
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: "${{ steps.node-version.outputs.NODE_VERSION }}"

@sevenc-nanashi
Copy link
Member Author

変更しましたー。

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

修正ありがとうございます!!

@Hiroshiba Hiroshiba merged commit 7f8e878 into VOICEVOX:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants