Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fixを実行しました #1205

Merged
merged 1 commit into from
Feb 15, 2023
Merged

npm audit fixを実行しました #1205

merged 1 commit into from
Feb 15, 2023

Conversation

stmtk1
Copy link
Contributor

@stmtk1 stmtk1 commented Feb 15, 2023

内容

npm auditを実行したらcriticalなものがいくつかあったので、npm audit fixを実行しました。

関連 Issue

スクリーンショット・動画など

その他

一応npm run test:unitを実行しておきました。

@stmtk1 stmtk1 requested a review from a team as a code owner February 15, 2023 12:00
@stmtk1 stmtk1 requested review from Hiroshiba and removed request for a team February 15, 2023 12:00
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

手元でも動かしてみたのですが全く一緒のファイルが生成されました!
ありがとうございます!!

問題ないと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 9aab73c into VOICEVOX:main Feb 15, 2023
@Hiroshiba
Copy link
Member

githubのabout meを見させていただいたのですが、RustもPythonもwebもできるんですね・・・!!

VOICEVOXはちょうどこの3つの言語を扱っています!(ご存知だったらすみません)
https://github.com/VOICEVOX/.github/blob/main/profile/README.md

もしコミットにご興味あれば、初心者歓迎タスクラベルなどが参考になるかと・・・!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants