-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: デフォルトスタイルのダイアログが閉じれないバグを修正 #1197
Merged
Hiroshiba
merged 5 commits into
VOICEVOX:main
from
sevenc-nanashi:fix/softlock-default-style
Feb 11, 2023
Merged
Fix: デフォルトスタイルのダイアログが閉じれないバグを修正 #1197
Hiroshiba
merged 5 commits into
VOICEVOX:main
from
sevenc-nanashi:fix/softlock-default-style
Feb 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
February 11, 2023 14:03
Hiroshiba
reviewed
Feb 11, 2023
Hiroshiba
reviewed
Feb 11, 2023
Co-authored-by: Hiroshiba <[email protected]>
Hiroshiba
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!コメントだけ追加しました!
filterしちゃう方式で、問題も起きますが、まあ良いかなと思いました!
(問題が起きないようにするコードにするのもそこそこ大変なので。。)
メンテナ判断ですが、hotfixリリースしたいと思います!
ツイッターでリリース告知はせず、こそっとhotfixする感じを考えています。
Hiroshiba
reviewed
Feb 11, 2023
Hiroshiba
pushed a commit
that referenced
this pull request
Feb 11, 2023
Co-authored-by: Hiroshiba <[email protected]> closes undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
デフォルトスタイルのダイアログが閉じれない場合があるのを修正します。
関連 Issue
スクリーンショット・動画など
(なし)
その他
release-0.14に入れてhotfixリリースしても良いかも…?