ENH: プロジェクトファイルをエンジンが起動した後に読み込まれるようにする #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jan 25, 2023
Hiroshiba
reviewed
Jan 25, 2023
Hiroshiba
reviewed
Jan 25, 2023
|
修正完了しました。 |
Hiroshiba
reviewed
Jan 26, 2023
Hiroshiba
reviewed
Jan 26, 2023
src/views/EditorHome.vue
Outdated
| }); | ||
| if (!result) { | ||
| store.commit("SET_PROJECT_FILEPATH", {}); |
There was a problem hiding this comment.
ここもLOAD_PROJECT_FILEが失敗していたらそもそもSET_PROJECT_FILEPATHされないかなと思いました！
Hiroshiba
reviewed
Jan 26, 2023
最初のセルの作成を修正
Hiroshiba
reviewed
Jan 27, 2023
Hiroshiba
reviewed
Feb 1, 2023
Hiroshiba
reviewed
Feb 1, 2023
Comment on lines
+346
to
+364
| if (isMac) { | ||
| if (filePathOnMac) { | ||
| if (filePathOnMac.endsWith(".vvproj")) { | ||
| projectFilePath = encodeURI(filePathOnMac); | ||
| } | ||
| filePathOnMac = undefined; | ||
| } | ||
| } else { | ||
| if (process.argv.length >= 2) { | ||
| const filePath = process.argv[1]; | ||
| if ( | ||
| fs.existsSync(filePath) && | ||
| fs.statSync(filePath).isFile() && | ||
| filePath.endsWith(".vvproj") | ||
| ) { | ||
| projectFilePath = encodeURI(filePath); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
ここロジック綺麗にできそうだなと思いました。
Macだったとき・そうじゃないときでfilePathを先に作って、後ろで
if (
fs.existsSync(filePath) &&
fs.statSync(filePath).isFile() &&
filePath.endsWith(".vvproj")
) {
projectFilePath = encodeURI(filePath);
}する感じを想像しています。
（コード移した感じなので修正は気が向いたらで十分かなと！）
There was a problem hiding this comment.
ちょっとMac周りを弄るのが怖いので一旦このままにしておきます
Hiroshiba
reviewed
Feb 1, 2023
Hiroshiba
approved these changes
Feb 1, 2023
Co-authored-by: Hiroshiba <[email protected]>
|
あっすみません、isSafeModeをisMultiEngineOffModeに名称変更したところとコンフリクトしてしまいました･･･ 🙇♂️ |
|
マージしました。 |
Hiroshiba
reviewed
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
プロジェクトファイルからVOICEVOXを起動したときにエンジンが起動した後にプロジェクトファイルを読み込むように変更します。
これによりマイグレーションに必要なデータをエンジンから取得できるようになります。
関連 Issue
その他
Windowsしか持っていないため他のOSで動作確認をしていません。